Introduced search support for multiple programming languages #116
Conversation
starcli/__main__.py
Outdated
| @@ -19,12 +20,19 @@ | |||
|
|
|||
|
|
|||
| # could be made into config option in the future | |||
| CACHED_RESULT_PATH = xdg_cache_home() / "starcli.json" | |||
| CACHED_RESULT_PATH = Path(BaseDirectory.xdg_cache_home) / "starcli.json" | |||
There was a problem hiding this comment.
This one is weird, but basically doing pip3 install -r requirements_dev.txt installs a version of xdg that does not export xdg_cache_home as is. Possibly a breaking change in some of the minor/patch version of xdg? I've double-checked it with fresh venv - same problem.
There was a problem hiding this comment.
That's weird, I've tested with python 3.8 and 3.10, on both ubuntu and arch. Are you having this issue by installing from PyPI as well?
What is your OS and python version?
|
Thanks for the PR! I'll take a look when I'm free. |
|
Hi @dzmitry-kankalovich. This has been merged without the xdg.BaseDirectory change. If you're still having issues with it, please open a separate issue and I'll be happy to help debug it further. 🙂 @all-contributors please add @dzmitry-kankalovich for code. |
|
I've put up a pull request to add @dzmitry-kankalovich! 🎉 |
Checklist
Description
Similar to #108 implementation of multiple programming languages support. The reason for another changeset is that the original PR seems to be stale. This one is up to date + fixed/added tests.